New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinity rerender with NaN value #460

Open

nikmilson wants to merge 1 commit into christianalfoni:master from nikmilson:master

nikmilson commented Jul 12, 2017

Using value={NaN} causes infinity rerender, because of isSame(NaN, NaN) returns false due to NaN === NaN is false (https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/NaN).

This PR fixes isSame function for this case. Test cases are added.


          Fix infinity rerender with NaN value

9b0148a

nikmilson closed this by deleting the head repository

nikmilson reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet